Pr1/increase_RebootManager_and_PatchAssessor_code coverage #267
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into pr1/increase_code_coverage pull master changes
…into pr1/increase_code_coverage pull origin master changes
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #267 +/- ##
==========================================
+ Coverage 91.84% 91.98% +0.13%
==========================================
Files 90 90
Lines 15596 15624 +28
==========================================
+ Hits 14324 14371 +47
+ Misses 1272 1253 -19
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
feng-j678
changed the title
feng-j678
requested review from
kjohn-msft,
najams and
rane-rajasi
as code owners
…into pr1/increase_code_coverage pull master changes.
rane-rajasi
reviewed
Oct 21, 2024
rane-rajasi
reviewed
Oct 21, 2024
rane-rajasi
requested changes
Oct 21, 2024
Contributor
rane-rajasi
left a comment
rane-rajasi
left a comment
There was a problem hiding this comment.
PR has multiple independent changes in it. We have discussed about not adding changes unrelated to the main goal of a PR in it. PR title mentions increasing reboot manager coverage, but this also has stringIO bug fix and a test case for error handling in status file. This goes against what we've discussed earlier. Please split these out in to their own individual changes
feng-j678
changed the title
rane-rajasi
reviewed
Oct 25, 2024
…into pr1/increase_code_coverage pull master changes
…/LinuxPatchExtension into pr1/increase_code_coverage pull upstream branch changes
kjohn-msft
approved these changes
Nov 5, 2024
rane-rajasi
approved these changes
Nov 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[x] add ut to RebootManager.py
[x] add ut test_raise_add_error_to_status in PatchAssessor.py