Skip to content

Conversation

@rane-rajasi
Copy link
Contributor

@rane-rajasi rane-rajasi commented Aug 30, 2023

Changes to accept EULA based on a config in VM.

Pending items in this PR to be taken to the next one:

@rane-rajasi rane-rajasi requested a review from a team August 30, 2023 17:06
@rane-rajasi rane-rajasi requested review from najams and removed request for a team August 30, 2023 17:06
@rane-rajasi rane-rajasi requested a review from najams as a code owner August 30, 2023 17:06
@codecov
Copy link

codecov bot commented Aug 30, 2023

Codecov Report

Merging #215 (1c07157) into master (bd81687) will increase coverage by 0.11%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #215      +/-   ##
==========================================
+ Coverage   90.21%   90.33%   +0.11%     
==========================================
  Files          90       90              
  Lines       14539    14719     +180     
==========================================
+ Hits        13116    13296     +180     
  Misses       1423     1423              
Flag Coverage Δ
python27 90.33% <100.00%> (+0.11%) ⬆️
python39 90.33% <100.00%> (+0.11%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
src/core/src/bootstrap/Constants.py 98.63% <100.00%> (+0.03%) ⬆️
src/core/src/core_logic/ExecutionConfig.py 84.17% <100.00%> (+2.81%) ⬆️
src/core/src/core_logic/SystemctlManager.py 70.96% <100.00%> (ø)
...ore/src/package_managers/AptitudePackageManager.py 89.64% <100.00%> (+0.02%) ⬆️
src/core/tests/Test_AptitudePackageManager.py 99.63% <100.00%> (+0.13%) ⬆️
src/core/tests/library/ArgumentComposer.py 97.14% <100.00%> (+0.04%) ⬆️
src/core/tests/library/RuntimeCompositor.py 100.00% <100.00%> (ø)

Copy link
Collaborator

@kjohn-msft kjohn-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comments inline

Copy link
Collaborator

@kjohn-msft kjohn-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comments inline.

kjohn-msft
kjohn-msft previously approved these changes Sep 14, 2023
feng-j678
feng-j678 previously approved these changes Sep 14, 2023
@rane-rajasi rane-rajasi dismissed stale reviews from feng-j678 and kjohn-msft via dd4d23b September 14, 2023 21:39
feng-j678
feng-j678 previously approved these changes Sep 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants