Skip to content

Conversation

@feng-j678
Copy link
Contributor

@feng-j678 feng-j678 commented Jul 10, 2023

[x] address the bug - Terminal exception AttributeError - 'datetime.timedelta' object has no attribute 'total_seconds'
[x]raise exception if min python version is < 2.7

apis call result
image

@codecov
Copy link

codecov bot commented Jul 10, 2023

Codecov Report

Merging #207 (aada10b) into master (05fb0aa) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #207      +/-   ##
==========================================
+ Coverage   90.11%   90.14%   +0.02%     
==========================================
  Files          90       90              
  Lines       14442    14475      +33     
==========================================
+ Hits        13015    13048      +33     
  Misses       1427     1427              
Flag Coverage Δ
python27 90.14% <100.00%> (+0.02%) ⬆️
python39 90.14% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/core/tests/Test_CoreMain.py 99.88% <ø> (-0.01%) ⬇️
src/core/src/bootstrap/Constants.py 98.59% <100.00%> (+<0.01%) ⬆️
src/core/src/core_logic/PatchAssessor.py 99.39% <100.00%> (+0.03%) ⬆️
src/core/src/core_logic/PatchInstaller.py 96.66% <100.00%> (+0.06%) ⬆️
src/core/tests/Test_PatchAssessor.py 99.25% <100.00%> (+0.04%) ⬆️
src/core/tests/Test_PatchInstaller.py 99.80% <100.00%> (+<0.01%) ⬆️

@feng-j678 feng-j678 marked this pull request as ready for review July 17, 2023 17:46
Copy link
Collaborator

@kjohn-msft kjohn-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comments inline.

Copy link
Contributor

@rane-rajasi rane-rajasi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Questions inline

@kjohn-msft kjohn-msft merged commit 4fa74fa into master Jul 17, 2023
@kjohn-msft kjohn-msft deleted the user/jf/throw_python_version_exception branch July 17, 2023 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants