Skip to content

Conversation

@feng-j678
Copy link
Contributor

@feng-j678 feng-j678 commented Jul 6, 2023

[x] add logic to remove old complete status file in status folder
[x] refactor json.loads(message) in load_status_file_components()
[x] add unit test for remove old complete status file()

image

image

Copy link
Contributor

@rane-rajasi rane-rajasi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comments inline

@codecov
Copy link

codecov bot commented Jul 17, 2023

Codecov Report

Merging #205 (7543faf) into master (dae984a) will increase coverage by 0.04%.
The diff coverage is 98.46%.

@@            Coverage Diff             @@
##           master     #205      +/-   ##
==========================================
+ Coverage   90.19%   90.23%   +0.04%     
==========================================
  Files          90       90              
  Lines       14483    14533      +50     
==========================================
+ Hits        13063    13114      +51     
+ Misses       1420     1419       -1     
Flag Coverage Δ
python27 90.23% <98.46%> (+0.04%) ⬆️
python39 90.23% <98.46%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
src/core/src/service_interfaces/StatusHandler.py 94.80% <96.29%> (+0.40%) ⬆️
src/core/src/bootstrap/Constants.py 98.59% <100.00%> (+<0.01%) ⬆️
src/core/tests/Test_StatusHandler.py 99.77% <100.00%> (+0.01%) ⬆️

rane-rajasi
rane-rajasi previously approved these changes Jul 25, 2023
Copy link
Collaborator

@kjohn-msft kjohn-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please review the comment inline with @rane-rajasi

@feng-j678 feng-j678 force-pushed the user/jf/remove_old_complete_status_file branch from 7578725 to dbe796b Compare July 25, 2023 22:18
kjohn-msft
kjohn-msft previously approved these changes Jul 25, 2023
Copy link
Contributor

@rane-rajasi rane-rajasi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment inline

@feng-j678 feng-j678 force-pushed the user/jf/remove_old_complete_status_file branch from d8efa2f to d44d724 Compare July 28, 2023 19:31
@feng-j678 feng-j678 force-pushed the user/jf/remove_old_complete_status_file branch from 6759eec to 10dd4c6 Compare July 28, 2023 19:52
kjohn-msft
kjohn-msft previously approved these changes Jul 28, 2023
Copy link
Contributor

@rane-rajasi rane-rajasi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left minor comments

rane-rajasi
rane-rajasi previously approved these changes Aug 4, 2023
Copy link
Contributor

@rane-rajasi rane-rajasi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@feng-j678 I've left one minor comment. Please do take a look at it before merging

Copy link
Contributor

@rane-rajasi rane-rajasi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed from the extension lifecycle perspective as well, doesn't seem to change any existing functionality or adding orphan files during other handler events (i.e. non-enable)

@kjohn-msft kjohn-msft merged commit 3d68c37 into master Aug 21, 2023
@kjohn-msft kjohn-msft deleted the user/jf/remove_old_complete_status_file branch August 21, 2023 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants