Skip to content

Conversation

@kjohn-msft
Copy link
Collaborator

Internal tracker: 24467908

Issue:
Systemd was reporting the assessment service as failed (even though it hadn't), because of the way the process hierarchy is set up.
This was showing up as:
"Active: failed (result: protocol)" in reporting.

Fix:
Change the type to forking to reflect shell script invoking py code.

@kjohn-msft kjohn-msft requested a review from feng-j678 July 6, 2023 16:11
@codecov
Copy link

codecov bot commented Jul 6, 2023

Codecov Report

Merging #203 (07f7f24) into master (2e5c14b) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #203   +/-   ##
=======================================
  Coverage   90.07%   90.07%           
=======================================
  Files          90       90           
  Lines       14423    14423           
=======================================
  Hits        12991    12991           
  Misses       1432     1432           
Flag Coverage Δ
python27 90.07% <100.00%> (ø)
python39 90.07% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/core/src/core_logic/ServiceManager.py 49.23% <100.00%> (ø)

@kjohn-msft kjohn-msft merged commit b7d2203 into master Jul 6, 2023
@kjohn-msft kjohn-msft deleted the kjohn-aa-noisefix branch July 6, 2023 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants