Skip to content

Conversation

@SathishMSFT
Copy link
Member

@SathishMSFT SathishMSFT commented Jun 29, 2023

Adding telemetry log to get count of ESM packages selected to install.

Test:

  • Ubuntu 18 Unattached.
  • Ubuntu 18 Attached.

@codecov
Copy link

codecov bot commented Jun 29, 2023

Codecov Report

Merging #202 (9f7efb4) into master (2e5c14b) will increase coverage by 0.04%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #202      +/-   ##
==========================================
+ Coverage   90.07%   90.12%   +0.04%     
==========================================
  Files          90       90              
  Lines       14423    14445      +22     
==========================================
+ Hits        12991    13018      +27     
+ Misses       1432     1427       -5     
Flag Coverage Δ
python27 90.12% <100.00%> (+0.04%) ⬆️
python39 90.12% <100.00%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/core/src/core_logic/PatchAssessor.py 99.36% <100.00%> (ø)
src/core/src/core_logic/PatchInstaller.py 96.60% <100.00%> (ø)
...ore/src/package_managers/AptitudePackageManager.py 89.67% <100.00%> (+0.04%) ⬆️
src/core/src/package_managers/PackageManager.py 78.80% <100.00%> (ø)
src/core/src/package_managers/YumPackageManager.py 83.33% <100.00%> (ø)
.../core/src/package_managers/ZypperPackageManager.py 87.70% <100.00%> (ø)

... and 4 files with indirect coverage changes

@SathishMSFT SathishMSFT marked this pull request as ready for review June 29, 2023 09:54
nikhim-um
nikhim-um previously approved these changes Jun 30, 2023
Copy link
Collaborator

@kjohn-msft kjohn-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comments inline

Copy link
Contributor

@rane-rajasi rane-rajasi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment inline

@SathishMSFT SathishMSFT merged commit f3b7c7b into master Jul 12, 2023
@SathishMSFT SathishMSFT deleted the satimEsmTele branch July 12, 2023 04:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants