User/jf/add complete status file logic #195
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feng-j678
requested review from
kjohn-msft,
najams and
rane-rajasi
as code owners
Codecov Report
@@ Coverage Diff @@
## master #195 +/- ##
==========================================
+ Coverage 90.07% 90.11% +0.04%
==========================================
Files 90 90
Lines 14423 14443 +20
==========================================
+ Hits 12991 13016 +25
+ Misses 1432 1427 -5
Flags with carried forward coverage won't be shown. Click here to find out more.
|
kjohn-msft
reviewed
Jun 16, 2023
kjohn-msft
reviewed
Jun 16, 2023
kjohn-msft
reviewed
Jun 16, 2023
rane-rajasi
reviewed
Jun 16, 2023
rane-rajasi
reviewed
Jun 16, 2023
rane-rajasi
reviewed
Jun 16, 2023
rane-rajasi
reviewed
Jun 16, 2023
rane-rajasi
reviewed
Jun 16, 2023
rane-rajasi
reviewed
Jun 16, 2023
rane-rajasi
reviewed
Jun 16, 2023
rane-rajasi
reviewed
Jun 20, 2023
rane-rajasi
reviewed
Jun 20, 2023
rane-rajasi
reviewed
Jun 20, 2023
rane-rajasi
reviewed
Jun 20, 2023
rane-rajasi
reviewed
Jun 20, 2023
rane-rajasi
reviewed
Jun 20, 2023
…into user/jf/add_complete_status_file_logic
feng-j678
force-pushed
the
user/jf/add_complete_status_file_logic
branch
from
dc700c9 to
3d12da9
Compare
kjohn-msft
reviewed
Jun 22, 2023
kjohn-msft
reviewed
Jun 22, 2023
kjohn-msft
reviewed
Jun 22, 2023
kjohn-msft
requested changes
Jun 22, 2023
Collaborator
kjohn-msft
left a comment
kjohn-msft
left a comment
There was a problem hiding this comment.
Minor comments, okay on rest.
rane-rajasi
reviewed
Jun 22, 2023
rane-rajasi
reviewed
Jun 22, 2023
rane-rajasi
reviewed
Jun 22, 2023
…ntWithConfigurePatching={3}]
…into user/jf/add_complete_status_file_logic
kjohn-msft
approved these changes
Jul 6, 2023
rane-rajasi
reviewed
Jul 6, 2023
rane-rajasi
approved these changes
Jul 6, 2023
Contributor
rane-rajasi
left a comment
rane-rajasi
left a comment
There was a problem hiding this comment.
One minor comment left open. Leaving upto @feng-j678 whether or not to include the suggestion in this or next PR.
Branch shows out of sync with master, please resolve that before merging
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is in this PR:
[X] rewrite logic to write status_payload to complete_status_file_path w/o truncation
[X] add unit test