Add ordered dictionary for quicker look up of Installation packages in StatusHandler #194
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feng-j678
requested review from
kjohn-msft,
najams and
rane-rajasi
as code owners
Codecov Report
@@ Coverage Diff @@
## master #194 +/- ##
==========================================
+ Coverage 90.01% 90.07% +0.05%
==========================================
Files 90 90
Lines 14356 14423 +67
==========================================
+ Hits 12923 12991 +68
+ Misses 1433 1432 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
kjohn-msft
previously approved these changes
Jun 16, 2023
rane-rajasi
reviewed
Jun 16, 2023
rane-rajasi
reviewed
Jun 16, 2023
rane-rajasi
reviewed
Jun 16, 2023
feng-j678
force-pushed
the
user/jf/add_orderdict_installation
branch
from
66fd848 to
86e2209
Compare
rane-rajasi
reviewed
Jun 19, 2023
rane-rajasi
reviewed
Jun 19, 2023
rane-rajasi
reviewed
Jun 19, 2023
feng-j678
force-pushed
the
user/jf/add_orderdict_installation
branch
2 times, most recently
from
52245e1 to
cc2b9a2
Compare
feng-j678
force-pushed
the
user/jf/add_orderdict_installation
branch
from
cc2b9a2 to
49a32af
Compare
kjohn-msft
previously approved these changes
Jun 20, 2023
rane-rajasi
previously approved these changes
Jun 21, 2023
Contributor
rane-rajasi
left a comment
rane-rajasi
left a comment
There was a problem hiding this comment.
@feng-j678 Now that the py27 CI issue is fixed, let that PR go in first, so you can fetch latest from master into this PR, run py27 on this PR and then merge.
kjohn-msft
changed the title
…into user/jf/add_orderdict_installation
rane-rajasi
approved these changes
Jun 21, 2023
kjohn-msft
approved these changes
Jun 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is in this PR:
[X] Modify the nested for loop in set_package_install_status and set_package_install_status_classification to use order dictionary for quicker look up
[X] unit test installation order dictionary