Skip to content

Conversation

@feng-j678
Copy link
Contributor

  • Never reboot is selected and there's reboot pending in reboot manager, set the patch status to warning

…into bugfix/neverReboot_is_selected_change_patch_status_to_completedWithWarning
@codecov
Copy link

codecov bot commented Apr 13, 2023

Codecov Report

Merging #188 (5cdc796) into master (67278b8) will increase coverage by 0.10%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #188      +/-   ##
==========================================
+ Coverage   89.17%   89.28%   +0.10%     
==========================================
  Files          90       90              
  Lines       13323    13426     +103     
==========================================
+ Hits        11881    11987     +106     
+ Misses       1442     1439       -3     
Flag Coverage Δ
python27 87.95% <100.00%> (+0.16%) ⬆️
python39 89.15% <100.00%> (+0.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/core/src/core_logic/PatchInstaller.py 86.92% <100.00%> (+0.87%) ⬆️
src/core/src/core_logic/RebootManager.py 75.64% <100.00%> (+1.61%) ⬆️
src/core/tests/Test_CoreMain.py 99.88% <100.00%> (+0.01%) ⬆️
src/core/tests/Test_PatchInstaller.py 99.56% <100.00%> (+0.01%) ⬆️
src/core/tests/Test_RebootManager.py 98.78% <100.00%> (+0.13%) ⬆️

kjohn-msft
kjohn-msft previously approved these changes May 1, 2023
@feng-j678 feng-j678 merged commit f67a65a into master May 11, 2023
@feng-j678 feng-j678 deleted the bugfix/neverReboot_is_selected_change_patch_status_to_completedWithWarning branch May 11, 2023 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants