Skip to content

Conversation

@SathishMSFT
Copy link
Member

@SathishMSFT SathishMSFT commented Mar 27, 2023

What is in this PR:
[X] Minimum pro client version
[X] Skeleton get_all_updates
[X] Implement get_all_updates
[X] Implement get_security_updates
[X] Implement get_security_esm_updates
[X] Implement is_pro_client_attached method and add it to error object
[X] Common code changes( e.g.. status update to reflect esm packages ...)
[X] Testing patching and assessment operation.
[X] Mark Patching operation failed when there are esm packages to updates and VM not attached.
[X] Add error details for assessment where VM is un-attached and has esm packages.
[X] Implement changes to skip and fail esm packages on a un-attached VM. Mark the overall status as "Warning" in this scenario.
[X] Additional error condition checks
[X] Testing on supported versions (18.04), and unsupported versions (20.04).
[X] Unit test coverage..
[X] Add error detail of reboot status when we set status as warning.
[] Adding Telemetry data points for both reboot status and updates.

  • Reboot status using pro and mismatch count.
  • esm package count. if possible
  • updates mismatch count.

What will not be in this PR:

  • ESM changes for base apt
  • pro api changes to get updates (This will depend on when canonical fixes it)

Copy link
Contributor

@rane-rajasi rane-rajasi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SathishMSFT, code coverage failed for python 3 and hence did not run for python 2. Please check and ensure both of these succeed.

@SathishMSFT
Copy link
Member Author

@SathishMSFT, code coverage failed for python 3 and hence did not run for python 2. Please check and ensure both of these succeed.

Failed intermittently. Re-ran passed.

@kjohn-msft
Copy link
Collaborator

@rane-rajasi please review for final pass.

Copy link
Contributor

@rane-rajasi rane-rajasi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SathishMSFT 3 minor comments active from me. 2 are from last review, and 1 is a todo after PR merge, please look into it. Outside of it everything looks good.

@SathishMSFT
Copy link
Member Author

@SathishMSFT 3 minor comments active from me. 2 are from last review, and 1 is a todo after PR merge, please look into it. Outside of it everything looks good.

I have addressed the unittest. Will skip the method name change as there is already property by same name. Will work with John to get the document updated once checked in.

@SathishMSFT SathishMSFT merged commit e1beafc into master Jun 15, 2023
@SathishMSFT SathishMSFT deleted the satimpro branch June 15, 2023 06:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants