Skip to content

Adapt to lastest hie-bios breaking api changes #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 10, 2020
Merged

Adapt to lastest hie-bios breaking api changes #1

merged 2 commits into from
Sep 10, 2020

Conversation

jneira
Copy link
Collaborator

@jneira jneira commented Sep 10, 2020

Avi-D-coder
Avi-D-coder approved these changes Sep 10, 2020
View reviewed changes
Copy link
Owner

@Avi-D-coder Avi-D-coder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for handling this

fendor
fendor approved these changes Sep 10, 2020
View reviewed changes
Copy link

@fendor fendor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@Avi-D-coder
Copy link
Owner

@jneira Is this ready to merge?

@jneira
Copy link
Collaborator Author

jneira commented Sep 10, 2020

@Avi-D-coder i think so, thanks for the invite!

@Avi-D-coder Avi-D-coder merged commit f7bfc24 into Avi-D-coder:master Sep 10, 2020
@pepeiborra pepeiborra mentioned this pull request Sep 13, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Avi-D-coder Avi-D-coder Avi-D-coder approved these changes

+1 more reviewer

@fendor fendor fendor approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jneira @Avi-D-coder @fendor