refactor: remove utils.options / utils.object.shallowCopy
#14156
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hasezoey
added
the
refactor
it was for shallow-copying objects, which is now solved by spread-operators
hasezoey
force-pushed
the
removeUtilsOptions
branch
from
6820605 to
06fe36d
Compare
… of "utils.options"
hasezoey
force-pushed
the
removeUtilsOptions
branch
from
06fe36d to
006740a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR removes function
utils.options(lib/utils.js) which shallow-copies objects, which is now solved with JS-native spread-operator.i got this idea because of #14155.
my only concern would be the removal of
clone's that was done previously (with 6820605), no tests fail and the comments mentioned it was becauseutils.optionsdirectly assigned to the second parameter.as for performance, i have not measured, but i would assume it is about the same, if not better thanks to the removal of
clones