fix(schema): correctly handle uuids with populate()
#13317
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AbdelrahmanHafez
approved these changes
Apr 24, 2023
Collaborator
AbdelrahmanHafez
left a comment
AbdelrahmanHafez
left a comment
There was a problem hiding this comment.
LGTM, thanks. 👍
hasezoey
approved these changes
Apr 24, 2023
Collaborator
hasezoey
left a comment
hasezoey
left a comment
There was a problem hiding this comment.
LGTM, with some minor additions
Co-authored-by: hasezoey <[email protected]>
|
Is there any chance of getting this patched into the v6 branch? |
2 tasks
vkarpov15
added a commit
that referenced
this pull request
Jul 11, 2023
vkarpov15
added a commit
that referenced
this pull request
Jul 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #13267
Summary
Couple of fixes to make UUIDs work better with populate:
Examples