fix(types): avoid typeof Query with generics for TypeScript 4.6 support #12712
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hasezoey
approved these changes
Nov 23, 2022
Collaborator
hasezoey
left a comment
hasezoey
left a comment
There was a problem hiding this comment.
LGTM
maybe consider adding a TODO or REFACTOR comment to update this part for the next major version (which presumably will set the minimal typescript version instead of being vaguely defined)
Uzlopak
approved these changes
Nov 23, 2022
AbdelrahmanHafez
approved these changes
Nov 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #12688
Fix #12689
Summary
A more robust fix for #12689, which mostly does what we expect. It looks like we do lose the generics with
toConstructor(), but I think this approach is better than Mongoose compilation crashing on TypeScript 4.6.Examples