EntList Integration Tests #34

sankalps0549 · 2025-11-24T23:30:47Z

Description

This PR introduces the integration tests for the EntList class.

Changes in this PR:

Updates to all the study files in the meshed_studies project, i.e. 3d_model, dd_model, midplane_model. The change includes adding a new saved list to the study.
Introduced the test suite test_suite_ent_list
Added test_integration_ent_list.py
Updated pytest markers with ent_list
Added ent_list pytest marker to the test_unit_ent_list.py class

Type of change

Please delete options that are not relevant.

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
Documentation update

Checklist

Please delete options that are not relevant.

I have read the CONTRIBUTING document
My code follows the style guidelines of this project
I have added tests that prove my fix is effective or that my feature works
New and existing unit tests pass locally with my changes
I have updated the documentation accordingly
I have added a note to CHANGELOG.md describing my changes
My changes generate no new warnings
Any dependent changes have been merged and published

Data Generation

python run.py generate-baseline-data ent_list

Testing

Added Integration Tests for the EntList class

python run.py test -m ent_list

Test Run:

Additional Notes

N/A

Copilot

Pull request overview

This PR adds integration tests for the EntList class to verify its functionality with real Moldflow Synergy COM objects. The tests cover entity selection, size checking, string conversion, and entity retrieval operations.

Key changes:

Created comprehensive integration tests for EntList class methods including select_from_string, select_from_predicate, convert_to_string, and entity
Added test data constants for three different model types (dd_model, midplane_model, 3d_model)
Registered ent_list pytest marker for test organization

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File	Description
tests/api/unit_tests/test_unit_ent_list.py	Added `ent_list` pytest marker to existing unit test class
tests/api/integration_tests/test_integration_ent_list.py	New integration test file with comprehensive test coverage for EntList functionality
tests/api/integration_tests/data/set_fields.py	Added test data constants for entity list integration tests
pytest.ini	Registered `ent_list` pytest marker

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

tests/api/integration_tests/test_integration_ent_list.py

Co-authored-by: Copilot <[email protected]>

Copilot

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated no new comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

osinjoku · 2025-11-24T23:44:34Z

Is it possible to also test select_from_saved_list in the EntList class?

sankalps0549 · 2025-11-25T00:01:28Z

Is it possible to also test select_from_saved_list in the EntList class?

Done, missed the function with original testing

…-api into ent-list-tests

Copilot

Pull request overview

Copilot reviewed 4 out of 5 changed files in this pull request and generated no new comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

miraladsk · 2025-11-26T04:36:13Z

tests/api/integration_tests/data/set_fields.py

+
+TEST_ENTITY_LIST_STRING = {
+    "dd_model": {
+        "items": "T56 T57",


There should be a reference to the underlying model.

miraladsk

I have few comments reg Integration architecture

For any newly created test, I would love to see only addition (no modification)
I don't see a point of maintaining zip file, any addition to zip impacts all existing test cases
Test specific data should be managed in specific folder (test name as folder)
Every validation of tests should be within test specific folder

@osinjoku Let me know if you have some opinion.
cc: @sankalps0549

sankalps0549 · 2025-11-26T18:23:25Z

I have few comments reg Integration architecture

For any newly created test, I would love to see only addition (no modification)

I don't see a point of maintaining zip file, any addition to zip impacts all existing test cases

Test specific data should be managed in specific folder (test name as folder)

Every validation of tests should be within test specific folder

@osinjoku Let me know if you have some opinion. cc: @sankalps0549

I will be addressing the points and raising another PR for the required infra changes. Drafted this PR for the time being.

About storing the study files, can we get a final decision @osinjoku @miraladsk, do we want to keep them zipped or unzipped.

…ent-list-tests

Copilot

Pull request overview

Copilot reviewed 8 out of 11 changed files in this pull request and generated 2 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

tests/api/integration_tests/test_suite_ent_list/generate_expected_data_ent_list.py

tests/api/integration_tests/test_suite_ent_list/test_integration_ent_list.py

Co-authored-by: Copilot <[email protected]>

miraladsk · 2025-12-03T01:58:19Z

tests/api/integration_tests/metadata.json

    "time": "06:58:32 UTC",
    "build_number": "49.1.198",
    "version": "2026"
+  },


I would consider this as an exception case, Going ahead, we should not see any changes in this file, Please improve infra

Will improve in the future

miraladsk · 2025-12-03T01:59:52Z

tests/api/integration_tests/study_files/project_meshed_studies/meshed_studies.mpi

 BEGIN PROPERTIES
 END PROPERTIES
-Last Write Time: Thu Nov  6 18:28:23 2025
+Last Write Time: Tue Dec  2 21:18:16 2025


Why the changes in sdy & mpi?

As noted in the PR description, this change updates all study files in the meshed_studies project (3d_model, dd_model, and midplane_model) by adding a new saved list to the study.

Is it just for this PR or going to happen for every subsequent PR?

If the study doesn't have something that we require for the tests, it might, but we don't expect to see this too often.

In that case, I would always expect a new study, Either you create study with full features or just keep on adding new,

My concern is that creating new study files for each requirement will add a lot of extra files to the repo unnecessarily. We should only add new ones when clearly needed.

True, why we can't anticipate all the required things in sdy (we already know the API list) and create a full-fledged study upfront?

That would require a separate, deeper review of every API, and in many cases the requirements aren’t immediately obvious. Instead of dedicating extra time solely for that, we’re updating the study files alongside the test development. Since all of this work is happening on a feature branch, by the time it’s merged into main we’ll end up with the finalized versions of the sdy and mpi files.

At least initial spike will reduce the number of changes in sdy file. My only worry is impact. When there is a change in sdy, all existing test cases are impacted and may fail and reviewer is not going to replay them on their machine

We don’t anticipate frequent updates to the study files, so it may be worth having this discussion again only if it starts occurring more often.

miraladsk · 2025-12-03T02:00:37Z

tests/api/unit_tests/test_unit_ent_list.py

 from unittest.mock import Mock
 import pytest
 from moldflow import EntList, Predicate



Why this file is shown as modified and not newly created?

We previously had unit tests without class-specific labels. Now that we’re introducing labels, we’re going back and adding them to the existing tests as well.

EntList Integration Tests

d8767b6

sankalps0549 requested a review from Copilot November 24, 2025 23:30

sankalps0549 self-assigned this Nov 24, 2025

Copilot AI reviewed Nov 24, 2025

View reviewed changes

tests/api/integration_tests/test_integration_ent_list.py Outdated Show resolved Hide resolved

Update tests/api/integration_tests/test_integration_ent_list.py

108871d

Co-authored-by: Copilot <[email protected]>

sankalps0549 requested a review from Copilot November 24, 2025 23:32

Copilot AI reviewed Nov 24, 2025

View reviewed changes

sankalps0549 requested review from KumarDev2003, LiawChungYao, miraladsk, omkar-p-adsk and osinjoku November 24, 2025 23:34

sankalps0549 added 2 commits November 25, 2025 05:33

SelectFromSavedList function test

5d6365e

Merge branch 'ent-list-tests' of https://github.com/Autodesk/moldflow…

f003e14

…-api into ent-list-tests

sankalps0549 requested a review from Copilot November 25, 2025 00:05

Copilot AI reviewed Nov 25, 2025

View reviewed changes

osinjoku approved these changes Nov 25, 2025

View reviewed changes

LiawChungYao approved these changes Nov 26, 2025

View reviewed changes

miraladsk requested changes Nov 26, 2025

View reviewed changes

sankalps0549 marked this pull request as draft November 26, 2025 05:29

miraladsk reviewed Nov 26, 2025

View reviewed changes

sankalps0549 added 3 commits December 2, 2025 14:34

Merge remote-tracking branch 'origin/feature/integration-tests' into …

395a7d9

…ent-list-tests

Refactoring for new infra

98c428e

SavedList tests

7312aae

sankalps0549 marked this pull request as ready for review December 2, 2025 15:54

sankalps0549 requested review from Copilot and miraladsk December 2, 2025 15:54

Copilot AI reviewed Dec 2, 2025

View reviewed changes

tests/api/integration_tests/test_suite_ent_list/generate_expected_data_ent_list.py Outdated Show resolved Hide resolved

tests/api/integration_tests/test_suite_ent_list/test_integration_ent_list.py Outdated Show resolved Hide resolved

Apply suggestions from code review

5887549

Co-authored-by: Copilot <[email protected]>

sankalps0549 requested review from LiawChungYao and osinjoku December 2, 2025 18:29

miraladsk requested changes Dec 3, 2025

View reviewed changes

miraladsk approved these changes Dec 3, 2025

View reviewed changes

miraladsk merged commit 936140a into feature/integration-tests Dec 3, 2025
19 checks passed

miraladsk deleted the ent-list-tests branch December 3, 2025 04:31

EntList Integration Tests #34

EntList Integration Tests #34

Uh oh!

Conversation

sankalps0549 commented Nov 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Changes in this PR:

Type of change

Checklist

Data Generation

Testing

Test Run:

Additional Notes

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

osinjoku commented Nov 24, 2025

Uh oh!

sankalps0549 commented Nov 25, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Choose a reason for hiding this comment

Uh oh!

miraladsk left a comment

Choose a reason for hiding this comment

Uh oh!

sankalps0549 commented Nov 26, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

sankalps0549 commented Nov 24, 2025 •

edited

Loading