This repository was archived by the owner on Aug 7, 2023. It is now read-only.
Cleanup and bugfixes #99
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move hte configuration to a key in the `package.json`, allowing Atom to be able to read the settings without having to load up the package code.
This removes any chance of ambiguity and has the potential to speed up activation a few ms.
Move to the `import` syntax for bringing in the dependencies. Note that since Atom calls the service provider function on package activation this doesn't make a big difference on performance.
Use the much cleaner async/await syntax to clean up the code around the execution of `ruby`.
Instead of making Atom lookup the settings on each lint call, observe them in the activation so this work isn't needlessly repeated.
Rename the variable to match every other linter provider.
Let the regex do it's job of text processing and don't feed it only parts of the output.
If the file changes between when the lint was triggered and the start of output processing simply tell Linter to not update the messages instead of attempting to mark a document in a different state from when the output was generated.
With the space in there some platforms treat the encoding as ` utf-8` instead of the desired `utf-8`. Since the `ruby` help text shows no space in there in the first place, this is more correct and works on platforms where it was broken before.
On files that have no issues, `ruby -wc` gives no output.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many small upgrades and cleanup to the code, generally bringing it in line with other current linter providers including:
configSchemageting them on every lint callAlso fixes a few bugs:
-E utf-8, treating the encoding from that asutf-8(with a space on the front. As the documentation doesn't show a space before the option, simply remove it to make this work on all platforms.atom-linter@8.