Skip to content
This repository was archived by the owner on Aug 7, 2023. It is now read-only.

Conversation

@walles
Copy link
Contributor

@walles walles commented Nov 18, 2016

Before this change, activation was done on Atom startup, whether or not
you actually had any Ruby files open.

With this change in place, we postpone activation until the Atom
Ruby grammar's first use.

This improves startup time of my Atom by about 20ms, thus fixing one of
the top startup time offenders according to TimeCop.

For some frame of reference, I have 87 packages installed, and Timecop
lists all packages with startup times above 5ms.

Before this change, activation was done on Atom startup, whether or not
you actually had any Ruby files open.

With this change in place, we postpone activation until the Atom
Ruby grammar's first use.

This improves startup time of my Atom by about 20ms, thus fixing one of
the top startup time offenders according to TimeCop.

For some frame of reference, I have 87 packages installed, and Timecop
lists all packages with startup times above 5ms.
@Arcanemagus
Copy link
Member

Lovely, this project has no specs huh? 😞

Looks like at some point #40 needs to be updated or replaced...

@Arcanemagus Arcanemagus merged commit 9db1abb into AtomLinter:master Nov 28, 2016
@Arcanemagus
Copy link
Member

Published in v1.2.3. 🎉

@walles
Copy link
Contributor Author

walles commented Nov 29, 2016

The lack of specs in this project saved me many minutes on my startup time rampage :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants