Skip to content

Conversation

@rhit-maroisem
Copy link
Contributor

Existing items can now be Custom fields on other items

  • you can check which item it is with a button
  • the system checks if you have selected a valid item
  • items can be redirected to
  • deleted items that were linked will show up as deleted
  • tests

@rhit-maroisem rhit-maroisem marked this pull request as ready for review January 24, 2026 17:45
@rhit-maroisem rhit-maroisem linked an issue Jan 24, 2026 that may be closed by this pull request
Copy link
Contributor

@rhit-steineig rhit-steineig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comments (nothing major)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

consider removing comments and console.log()s if they're not needed (lines 267, 279, 282, etc.)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

consider removing comments and console.log()s in this file also

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there's whitespace linting issues in this file, probably just need to run the autoformatter or convert spaces to tabs

async function redirectToItem(itemId: string) {
if (!browser) {
console.log('redirectToItem called during SSR 😬');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

emoji

Copy link
Contributor

@rhit-steineig rhit-steineig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rhit-maroisem rhit-maroisem merged commit a10e3cf into main Jan 27, 2026
1 check passed
@github-project-automation github-project-automation bot moved this from Unrefined to Done in Current Tasks Jan 27, 2026
@rhit-maroisem rhit-maroisem deleted the marosiem/item-custom-field branch January 27, 2026 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

New custom field type that links to items

3 participants