-
Notifications
You must be signed in to change notification settings - Fork 1
Custom field now has Item type #271
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
rhit-steineig
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see comments (nothing major)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
consider removing comments and console.log()s if they're not needed (lines 267, 279, 282, etc.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
consider removing comments and console.log()s in this file also
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there's whitespace linting issues in this file, probably just need to run the autoformatter or convert spaces to tabs
| async function redirectToItem(itemId: string) { | ||
| if (!browser) { | ||
| console.log('redirectToItem called during SSR 😬'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
emoji
…AtlasTracker/AssetAtlas into marosiem/item-custom-field
rhit-steineig
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Existing items can now be Custom fields on other items