Skip to content

Fix publish issues and reconfigure master for development #944

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Nov 8, 2019

Conversation

dcodeIO
Copy link
Member

@dcodeIO dcodeIO commented Nov 8, 2019

This PR should fix issues with publishing to GPR by

  • explicitly specifying the registry on npm publish
  • adding a "repository" field to the loader so we can publish multiple packages to a single repo

and reconfigures master, so if it is installed via npm (the old way), it results in a development install through npm. This is handled by a script run before publishing that amends the corresponding files to use dist files instead of running everything through ts-node.

As such, the PR also removes dist files from master, which CI won't like, but I figured that it's better to make a PR in case there are obvious mistakes.

@dcodeIO dcodeIO merged commit 1503f4d into master Nov 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant