SourceMap generation reads internal sources instead of from files #832
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- changed asinit to executable.
dcodeIO
reviewed
Sep 10, 2019
| console.log(sourceMap.sources) | ||
| for (const index in sourceMap.sources) { | ||
| let internalPath = sourceMap.sources[index].replace(/\.ts$/, ""); | ||
| let source = program.sources.find(source => source.internalPath === internalPath); |
Member
There was a problem hiding this comment.
Calls into the compiler without using a C-like API, hence is non-portable once we can compile the compiler itself to Wasm.
Contributor
Author
There was a problem hiding this comment.
Ah I had a feeling this was too easy.
Member
There was a problem hiding this comment.
But wait. This already happened before:
Line 522 in f9230cd
Member
There was a problem hiding this comment.
Oh, appears this made it through review before.
Contributor
Author
There was a problem hiding this comment.
Lol my bad. I think instead we should just keep a local map of internal paths to texts and external paths for the resolver.
Member
|
Should be fixed in #846 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #831