Skip to content

Fix casting to bool for strings #567

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Mar 31, 2019
Merged

Fix casting to bool for strings #567

merged 4 commits into from
Mar 31, 2019

Conversation

MaxGraey
Copy link
Member

Fix this cases

assert(!!"" == false);
assert(!!"\0" == true);
assert(!!"a" == true);

@MaxGraey
Copy link
Member Author

MaxGraey commented Mar 30, 2019 •
edited
Loading

Hmm, it seems Atom or some plugin remove aligned spaces automatically...

@MaxGraey MaxGraey requested a review from dcodeIO March 31, 2019 13:17
@dcodeIO
Copy link
Member

dcodeIO commented Mar 31, 2019

LGTM :)

@dcodeIO dcodeIO merged commit abf3de9 into AssemblyScript:master Mar 31, 2019
@MaxGraey MaxGraey deleted the fix-falsy-string branch March 31, 2019 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dcodeIO dcodeIO dcodeIO approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MaxGraey @dcodeIO