Add WASI bindings #562

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

dcodeIO merged 13 commits into master from wasi-bindings

Mar 31, 2019

Member

dcodeIO commented Mar 27, 2019 •

edited

Loading

This PR adds bindings for WASI, the WebAssembly System Interface. A test makes sure that it parses and initializes properly, and that struct layouts are matching.

Documentation reference: https://github.com/CraneStation/wasmtime/blob/master/docs/WASI-api.md
Implementation references:
- https://github.com/CraneStation/wasmtime/blob/master/wasmtime-wasi/src/wasm32.rs
- https://github.com/CraneStation/wasi-sysroot/blob/wasi/libc-bottom-half/headers/public/wasi/core.h

Open questions:

~~Will the structs "just work"?~~
~~Some constants use prefixes that seem to be unnecessary because implied by their enclosing enum,, see (resolved) comments below~~
~~Does it have to be wasi_unstable?~~


          Add WASI bindings

dbf0abe

dcodeIO commented

View reviewed changes

std/assembly/bindings/wasi.ts Outdated Show resolved Hide resolved

dcodeIO commented

View reviewed changes

std/assembly/bindings/wasi.ts Outdated Show resolved Hide resolved

dcodeIO commented

View reviewed changes

std/assembly/bindings/wasi.ts Outdated Show resolved Hide resolved

dcodeIO commented

View reviewed changes

std/assembly/bindings/wasi.ts Outdated Show resolved Hide resolved

dcodeIO commented

View reviewed changes

std/assembly/bindings/wasi.ts Outdated Show resolved Hide resolved

dcodeIO commented

View reviewed changes

std/assembly/bindings/wasi.ts Outdated Show resolved Hide resolved


          address my own comments

8fc4457

jedisct1 commented Mar 27, 2019

It has to be wasi_unstable. This is what wasm embedders will use, at least for now.

dcodeIO added 8 commits

March 27, 2019 22:05


          make it wasi_unstable

96dc211


          validate struct layout

a067982


          remove leftover comments

d0452ea


          mimic typed enums

aa6ed8e

fix

53a16fa

url

f3e1574


          details

0a2fbf8


          fix typo

8a7cb4c

willemneal mentioned this pull request

[WIP] lib/host #437

Closed

dcodeIO added 3 commits

March 29, 2019 01:43


          add prestat struct

11d9552


          decorator..

f4dcd22


          wasm64 asserts

c558c1d

Member Author

dcodeIO commented Mar 29, 2019

I think this should be as complete as it gets, unless there are further comments that is :)

dcodeIO merged commit 85de20c into master

dcodeIO deleted the wasi-bindings branch

September 20, 2019 09:06

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet