Add bswap post MVP polyfills #33
Conversation
|
Polyfilling future features where possible sounds like a great idea! What do you think of putting these in their own std file? |
Sure, I put this to polyfills.ts |
|
When I think about a future implementation as a builtin, this one would probably use generics instead. Do you think it's possible to implement bswap that way, by switching over |
|
I think about it. But bswap<u32 | i32> and bswap<u64 | i64> has very different implementation. Can I do something like this? function bswap<T = i32 | u32>(value: T): T {
....
}
function bswap<T = i64 | u64>(value: T): T {
....
} |
|
I believe that's not possible in TypeScript, so not possible in AssemblyScript as well. But, you could check for signedness by doing an overflowing addition or something and checking the pre and post result for |
|
Sure. This is draft bswap16 implementation needs rewrite |
|
With if/else after optimization we get flat optimized version for every static case |
…o add-bswap-post-mvp-polyfill
|
Done! |
MaxGraey
changed the title
std/portable.d.ts
Outdated
| /** [Polyfill] Performs the sign-agnostic reverse bytes **/ | ||
| declare function bswap<T = i8 | u8 | i16 | u16 | i32 | u32 | isize | usize>(value: T): T; | ||
| /** [Polyfill] Performs the sign-agnostic reverse bytes only for last 16-bit **/ | ||
| declare function bswap16<T = i8 | u8 | i16 | u16 | i32 | u32>(value: T): T; |
There was a problem hiding this comment.
Do these actually exist in the portable JS library (portable.js)? If not, you can just skip them in portable.d.ts.
There was a problem hiding this comment.
Ok, I'll implement this in portable.js
There was a problem hiding this comment.
Note that in portable, you have to decide for let's say i32 arguments only.
std/assembly/polyfills.ts
Outdated
|
|
||
| return <T>rotr<u64>(a | b, 32); | ||
| } | ||
| throw new TypeError("Unsupported type"); |
There was a problem hiding this comment.
In stdlib I am trying to use assertions instead of errors, just because errors add static string data to memory while assertions do not when turned off.
There was a problem hiding this comment.
Ideally, just an assertion without a string message, but a comment behind that shows up when using source maps, that is, unless we are implementing an existing JS interface that actually is specified to throw an error on specific occasions, of course.
…o add-bswap-post-mvp-polyfill
|
Looking good! Let me know when you are confident with this one. And can you remove the dist files from the PR? Just trying to be sure that external stuff depending on them doesn't break unintentionally. |
|
I think its ready to merge. But commits is pretty mess and unfortunately I can't squash this, so may be better create another PR with another clear history branch? |
|
Can just squash-merge this :) |
|
ok. If you can do it from your side |
|
Create another PR with squashed history because squash-merge has very strong requirements and not possible in current case. This PR can be closed |
…-update Sync with assemblyscript master
* Used advice from AssemblyScript#1116 This fixes the memory leak * Cleaned up the code Added a comment explaining all the hard coding
* 'master' of github.com:jedisct1/wasa: Fixed the memory leak for Time.sleep (AssemblyScript#33) Improve Descriptor (AssemblyScript#25) Bump assemblyscript from 0.9.2 to 0.9.4 (AssemblyScript#27) Deps Optimizations + update dependencies (AssemblyScript#21) Bump @as-pect/cli from 2.7.0 to 2.8.1 (AssemblyScript#23) Bump assemblyscript from 0.9.1 to 0.9.2 (AssemblyScript#24) Fix Date.now to return milliseconds instead of microseconds (AssemblyScript#19) Bump assemblyscript from 0.9.0 to 0.9.1 (AssemblyScript#17)
Current PR add byte swap operation polyfills
See additional Post MVP features
Think it makes sense?
TODO: