Remove unnecessary 'queuedImports.splice()' calls #232
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dcodeIO
reviewed
Sep 9, 2018
| @@ -490,40 +490,33 @@ export class Program extends DiagnosticEmitter { | |||
| } | |||
|
|
|||
| // queued imports should be resolvable now through traversing exports and queued exports | |||
| for (let i = 0; i < queuedImports.length;) { | |||
| let queuedImport = queuedImports[i]; | |||
| for (const queuedImport of queuedImports) { | |||
There was a problem hiding this comment.
Looks good, but can we keep the plain for-loop here? Just to be sure, because for-of isn't yet supported when compiling to WASM (somewhat due to the lack of iterators), even though we don't compile the compiler itself to WASM yet.
There was a problem hiding this comment.
What to do about for-of loops over maps?
|
This PR subsumed by #249 anyway. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that
queuedImportsis never looked at again after this loop. SincequeuedImports.splice(i, 1)is equivalent toi++if we don't care about the state ofqueuedImportsafter the loop, we can just convert this to an ordinaryfor-ofloop.As of this PR,
queuedImportsis only referenced twice: once to write to ininitializeImports, and once to loop over here.