Skip to content

Move assert inside branch for String.fromCodePoint #1847

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
May 12, 2021
Merged

Move assert inside branch for String.fromCodePoint #1847

merged 6 commits into from
May 12, 2021

Conversation

MaxGraey
Copy link
Member

@MaxGraey MaxGraey commented May 6, 2021

  • I've read the contributing guidelines

yjhmelody
yjhmelody reviewed May 6, 2021
View reviewed changes
@MaxGraey MaxGraey changed the title Move assert inside second arm for String.fromCodePoint Move assert inside branch for String.fromCodePoint May 12, 2021
@MaxGraey MaxGraey merged commit c5fdfbf into AssemblyScript:master May 12, 2021
@MaxGraey MaxGraey deleted the improve-fromCodePoint branch May 12, 2021 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dcodeIO dcodeIO dcodeIO approved these changes

+1 more reviewer

@yjhmelody yjhmelody yjhmelody left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MaxGraey @dcodeIO @yjhmelody