Skip to content

fix: Fix assert when calling a setter property #1802

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 26, 2021
Merged

fix: Fix assert when calling a setter property #1802

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2a31eb5
fix: Fix assert when calling a setter property
saulecabrera Apr 13, 2021
bbf6a37
Remove assertion on void type
saulecabrera Apr 19, 2021
ee03cb1
Use resolver#getTypeOfElement
saulecabrera Apr 19, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion src/compiler.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6335,7 +6335,16 @@ export class Compiler extends DiagnosticEmitter {
}
case ElementKind.PROPERTY: {
let propertyInstance = <Property>target;
let getterInstance = assert(propertyInstance.getterInstance);
let getterInstance = propertyInstance.getterInstance;

if (!getterInstance) {
this.error(
DiagnosticCode.Cannot_invoke_an_expression_whose_type_lacks_a_call_signature_Type_0_has_no_compatible_call_signatures,
expression.range, this.currentType.toString()
);
return module.unreachable();
}

let thisArg: ExpressionRef = 0;
if (propertyInstance.is(CommonFlags.INSTANCE)) {
thisArg = this.compileExpression(
Expand Down