Add explicit dependency on JaxB #76
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Java 9 added the Jigsaw module system and moved `java.xml.bind` into a module. This module is not active by default. It can be be activated by running with `--add-modules java.xml.bind` however as it is scheduled to be removed in Java 10 it is prudent to migrate away from it now. As such the `jaxb-api`, glassfishes `jaxb-runtime` reference implementation and its dependency `javax.activation` have been added as maven dependencies. Additionally the `maven-plugin-plugin` failed to execute the help goal. This appeared to be caused by the initializer blocks of the anonymous subclass of the array list in BinaryType. This has been resolved by incrementing the plugin version and using `Arrays.asList` and replacing the use of `ArrayList` with the more general `List` interface where necessary.
|
Looks good 👍 |
Artur-
added a commit
to vaadin/skeleton-starter-flow-spring
that referenced
this pull request
Jul 30, 2019
The maven-failsafe-plugin issue seems fixed in 2.22, used by Spring Boot The selenium-standalone-server-plugin issue seems fixed in Ardesco/driver-binary-downloader-maven-plugin#76
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Java 9 added the Jigsaw module system and moved
java.xml.bindintoa module. This module is not active by default. It can be be activated
by running with
--add-modules java.xml.bindhowever as it is scheduledto be removed in Java 10 it is prudent to migrate away from it now.
As such the
jaxb-api, glassfishesjaxb-runtimereferenceimplementation and its dependency
javax.activationhave been added asmaven dependencies.
Additionally the
maven-plugin-pluginfailed to execute the help goal.This appeared to be caused by the initializer blocks of the anonymous
subclass of the array list in BinaryType.
This has been resolved by incrementing the plugin version and using
Arrays.asListand replacing the use ofArrayListwith the moregeneral
Listinterface where necessary.