Skip to content

Conversation

Zyano
Copy link
Contributor

@Zyano Zyano commented Jan 6, 2020

Types of Changes

Prerequisites

Please make sure you can check the following two boxes:

  • [ X] I have read the CONTRIBUTING document
  • [X ] My code follows the code style of this project

Contribution Type

What types of changes does your code introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue, please reference the issue id)
  • [ X] New feature (non-breaking change which adds functionality, make sure to open an associated issue first)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • My change requires a change to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

Description

PR from discussion in #24

@claassistantio
Copy link

claassistantio commented Jan 6, 2020

CLA assistant check
All committers have signed the CLA.

@FlorianRappl FlorianRappl changed the base branch from master to devel January 6, 2020 18:46
@FlorianRappl
Copy link
Contributor

Thanks, a couple of things are missing though (I could also add them):

  • CHANGELOG entry (for 0.14)
  • Build system update (to also make / include the .NET 4.6 build)

Zyano added 2 commits January 6, 2020 20:34
Updated build.cake to build for .net framework 4.6
Updated changelog.md for 0.14.0 with support for .net framework 4.6 (net46)
@Zyano
Copy link
Contributor Author

Zyano commented Jan 6, 2020

Hey, I hope the two commit that relate to changelog.md and build.cake are what you had in mind if not then it might be easier to modify them yourself :)

@FlorianRappl
Copy link
Contributor

Hey, I hope the two commit that relate to changelog.md and build.cake are what you had in mind if not then it might be easier to modify them yourself :)

Looks awesome - much appreciated!

@FlorianRappl FlorianRappl merged commit 3fe649b into AngleSharp:devel Jan 6, 2020
@FlorianRappl FlorianRappl added this to the v0.14 milestone Jan 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants