test_harness - additional multichain tests #491
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fix bugs with math operations - trait FromWhole for easy creation of UnifiedNum from f64 & u64
- div, mul, div_floor, checked_div and other - primitives - targeting - fix whole number conversion to UnifiedNum
…dditional-multichain-tests
…dditional-multichain-tests
…dditional-multichain-tests
- RejectState - Unhealthy ApproveState - transitioning to Healthy ApproveState
elpiel
commented
May 20, 2022
Comment on lines
88
to
92
| // Address 7 | ||
| // ( | ||
| // *PUBLISHER_2, | ||
| // keystore_options(&format!("{}_keystore.json", *PUBLISHER_2), "ganache7"), | ||
| // ), |
There was a problem hiding this comment.
I've added it as a comment to be easier for addition if the need arises.
| channel_tick_timeout = 5000 | ||
| # for test_harness make it larger | ||
| # Default: 5000 | ||
| channel_tick_timeout = 8000 |
There was a problem hiding this comment.
I still get timeouts in test_harness sometimes, we have to check why this is - performance issue or something wrong with the services
|
Test is failing as it's comparing the Validator message, which contains a |
53 tasks
elpiel
commented
May 25, 2022
Comment on lines
+521
to
+523
| redis_pool: deadpool::managed::Object<crate::db::redis_pool::Manager>, | ||
| #[allow(dead_code)] | ||
| db_pool: deadpool::managed::Object<crate::db::tests_postgres::Manager>, |
There was a problem hiding this comment.
Because the Object was getting dropped tests failed randomly.
Object hold the Pool of Pools, so we must hold these values until the Application struct get drop itself
simzzz
approved these changes
May 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds additional multi-chain tests:
RejectStatefor CAMPAIGN_2 (on Chain # 1337) with multiple Events.RejectStateto unhealthyApproveState(is_healthy: false) for CAMPAIGN_2ApproveStateto health for CAMPAIGN_2