Follow patterns of plugin-node-tab #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wrap `registerEvents` as in `plugin-node-tab` examples, and properly set plugin config's `initialized` value to true once event is registered (instead of setting a non-existent value on the config to true: `patternlab.config[pluginName] = true`)
749
pushed a commit
to 749/plugin-node-data-inheritance
that referenced
this pull request
Feb 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wrap
registerEventsas inplugin-node-tabexamples, and properly set plugin config'sinitializedvalue totrueonce event is registered (instead of setting a non-existent value on the config to true:patternlab.config[pluginName] = true). Let me know if I'm missing any reason for discrepancies with the model pattern. Thanks for the plugin.