25.6.5 Antalya port of #709, #760, #866 - Rendezvous hashing #952
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Antalya 25.3: lock_object_storage_task_distribution_ms setting
13 tasks
13 tasks
zvonand
reviewed
Sep 17, 2025
| ObjectAttributes attributes; | ||
| }; | ||
|
|
||
| struct RelativePathWithMetadata |
There was a problem hiding this comment.
Some changes or explanations would be very suitable here. It is not obvious why a RelativePathWithMetadata object stores something called "command", what is task response, why it is here, and, most curious, why sometimes RelativePathWithMetadata does not store the relative path itself.
For me (a relatively new person in this code section) it took a while to understand what is going on here and why it looks strange
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
-- Improvement
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Rendezvous hashing (port of #709, #760, and #866)
Exclude tests: