Antalya 25.3: Backport of #79844 - ObjectStorageCluster table function return wrong count() after applyTrivialCount optimized #878
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…luster_wrong_count fix: ObjectStorageCluster table function return wrong count() after applyTrivialCount optimized
|
It looks like upstream's PR introduces changes that we already have in our branch. @ianton-ru Please take a look. |
ianton-ru
approved these changes
Jul 3, 2025
Enmk
added a commit
that referenced
this pull request
Jul 6, 2025
After merging #878 Bringing tests closer to upstream.
13 tasks
Enmk
added a commit
that referenced
this pull request
Jul 7, 2025
…ceberg Antalya 25.3 : Fix integration tests storage iceber (after #878)
Enmk
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Bug Fix (user-visible misbehavior in an official stable release)
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
IcebergS3 supports count optimization, but IcebergS3Cluster does not. As a result, the count() result returned in cluster mode may be a multiple of the number of replicas. (ClickHouse#79844 by @wxybear)
Exclude tests: