25.3 Antalya - Bugfix for Iceberg: Take ownership of Context for IcebergMetadata #839
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enmk
changed the title
Enmk
changed the title
svb-alt
added
antalya-25.6
port-antalya
ianton-ru
pushed a commit
that referenced
this pull request
Aug 4, 2025
…ntext 25.3 Antalya - Bugfix for Iceberg: Take ownership of Context for IcebergMetadata
13 tasks
|
Does not required in 25.6, fixed in upstream by other way (send context as parameter to each method) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Fixed Context expiration for Iceberg queries (introduced in #796)
Since 25.3 DataLakeDatabase creates storage with copy of context - https://github.com/Altinity/ClickHouse/blob/antalya-25.3/src/Databases/DataLake/DatabaseDataLake.cpp#L401
But no one takes ownership to this copy of context, and it is destroyed after end of
tryGetTableImpl.After #584 metadata are used to filter object, and can be loaded after table created.
In this case query failed with error
With this fix IcebergMetadata takes ownership to context.