feat(extract-topic): add support for schemaless values #98
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeqo
force-pushed
the
jeqo/extract-topic-schemaless
branch
3 times, most recently
from
ea052c1 to
7441f29
Compare
jjaakola-aiven
requested changes
Jun 21, 2023
Contributor
jjaakola-aiven
left a comment
jjaakola-aiven
left a comment
There was a problem hiding this comment.
Update the documentation accordingly in README.md.
| @NullAndEmptySource | ||
| void fieldName_NullOrEmptyValueOrMissingField_Skip(final String value) { | ||
| void fieldName_NullOrEmptyValue_NoSkip_Schemaless(final String value) { | ||
| final Map<String, Object> valueMap = new HashMap<>(); |
Contributor
There was a problem hiding this comment.
This and the test fieldName_NullOrEmptyValueOrMissingField_Skip_Schemaless could have extra fields in the map.
src/main/java/io/aiven/kafka/connect/transforms/ExtractTopic.java
Outdated
Show resolved
Hide resolved
jeqo
force-pushed
the
jeqo/extract-topic-schemaless
branch
from
7441f29 to
2dbe061
Compare
jjaakola-aiven
approved these changes
Jun 21, 2023
jeqo
force-pushed
the
jeqo/extract-topic-schemaless
branch
from
20aaa31 to
3b5ed7b
Compare
jjaakola-aiven
approved these changes
Jun 21, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ExtractTopictransform only supports schema-based values at the moment.This proposal extends this support to schema-less values as well (e.g. Maps or primitive values).
Resolves #90