Terminal API: option to disable 308 redirect logic #1558
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @gcatanese, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request enhances the Terminal API client by providing a new configuration option that allows users to explicitly disable the automatic following of HTTP 308 Permanent Redirects. This change gives developers more granular control over network behavior, enabling them to handle 308 responses as exceptions rather than automatic redirections, which can be crucial for specific integration patterns or debugging scenarios.
Highlights
- New Configuration Option: Introduced
enable308Redirectproperty (defaulttrue) in the SDK's configuration, allowing developers to control the handling of HTTP 308 Permanent Redirect responses. - Customizable 308 Redirect Behavior: When
enable308Redirectis set tofalse, the SDK will no longer automatically follow 308 redirects. Instead, it will throw anHttpClientExceptionwith the 308 status code, providing more explicit control over redirect handling. - Enhanced Error Handling: The
HttpClientExceptionnow includes a more descriptive message when a parsing error occurs, indicating the HTTP status code and the problematic response body. - Redirect Loop Prevention: Implemented logic to prevent infinite redirect loops by disabling further redirects for subsequent requests that are initiated as a result of a 308 redirect.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request introduces a new configuration option enable308Redirect to allow disabling the automatic 308 redirect handling in the Terminal API. The changes look good overall, and the new functionality is covered by a new test case. I have one suggestion to improve code clarity and remove redundancy in how the default value for the new option is handled.
gcatanese
force-pushed
the
disable-308-redirect
branch
from
73b2783 to
f3634bb
Compare
|
1 participant
Terminal API handles
308responses by redirecting to the correct regional endpoint #1540This PR introduces a new property
enable308Redirect(defaulttrue) to let developers opt out and disable the redirect logic. In this case the SDK returns an exceptionHttpClientExceptioninstead.