Skip to content

Conversation

@asarhaddon
Copy link
Contributor

No description provided.

@setton
Copy link
Member

setton commented Oct 20, 2020

Hello @asarhaddon - we're unable to merge this: our internal infrastructure uses sphinx 1.3, which chokes on this:

TypeError: lex() argument must be a lexer instance, not a class

(We're planning an upgrade to Sphinx 3, not 4... we're quite conservative).

Are you able to make this change in a backwards-compatible way, by any chance?

@asarhaddon
Copy link
Contributor Author

Hello.
I should have described the issue I was fixing more in detail.
Sphinx 3.2.1 accepts both a class or an instance, but warns that version 4 will only accept classes. I suggest to postpone this merge request until your migration to sphinx 3.

@setton setton added this to the sphinx3 milestone Oct 20, 2020
@setton setton self-assigned this Oct 20, 2020
@asarhaddon
Copy link
Contributor Author

The same change has been applied meanwhile in commit e7d4c55.

@asarhaddon asarhaddon closed this Oct 19, 2021
@asarhaddon asarhaddon deleted the doc-conf-sphinx4 branch October 19, 2021 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants