Fix CTRL-C on a program launched with rlimit #597

leocardao · 2023-06-15T12:39:35Z

setpgid should be used when the program is running in the background so as not to worry about signal propagation.

Now we detect whether we are a background process or not, and call setpgid accordingly.

IT-465

tools/rlimit/rlimit.c

tests/tests_e3/os/process/main_test.py

grouigrokon

Is it ok if aix, darwin and solaris executables are not rebuilt ?
All the other points discussed have been fixed, so, appart from those missing builds (which I am not sure are used anymore ?) MR should be ok for me.

tox.ini

tools/rlimit/rlimit.c

To correct CTRL-C, we stop setting rlimit as the foreground program and ignore the SIGTTOU signal. However, this does not allow rlimit to be used with an interactive terminal. To solve this problem, we introduce the --foreground option. IT-465

grouigrokon

Should ok now :)

leocardao requested review from Nikokrock and Helflym June 15, 2023 12:39

leocardao self-assigned this Jun 15, 2023

leocardao force-pushed the topic/fix-rlimit-ctrl-c branch from d041900 to 2af9e60 Compare June 15, 2023 15:37

leocardao requested a review from enzbang June 15, 2023 15:38

leocardao force-pushed the topic/fix-rlimit-ctrl-c branch from 2af9e60 to 55dd4a7 Compare June 16, 2023 12:20

leocardao changed the title ~~CTRL-C on a program launched with rlimit no longer worked correctly~~ Fix CTRL-C on a program launched with rlimit Jun 16, 2023

leocardao force-pushed the topic/fix-rlimit-ctrl-c branch 2 times, most recently from 58a3d10 to b61b1a5 Compare June 19, 2023 13:42

grouigrokon reviewed Jun 19, 2023

View reviewed changes

tools/rlimit/rlimit.c Outdated Show resolved Hide resolved

leocardao force-pushed the topic/fix-rlimit-ctrl-c branch 4 times, most recently from e171357 to 46fbe77 Compare June 21, 2023 16:29