Added support for Si4432 ISM Band #446
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pat-rogers
reviewed
Jun 5, 2025
| type On_Off_Mode is (Off, On); | ||
| type Chip_Power_State is (Idle, RX, TX) with Size => UInt2'Size; | ||
|
|
||
| type Frequency_Type is delta 0.1 range 240.0 .. 960.0 |
There was a problem hiding this comment.
For these types named "_Type" can you come up with better, more descriptive names? The ones above this line are very good, for example.
There was a problem hiding this comment.
Reduced the count of types and renamed some.
pat-rogers
reviewed
Jun 9, 2025
There was a problem hiding this comment.
I don't mean to be a jerk about this, but these _Type names are not in the ADL style. Those types in this package without that suffix are much better. For example, why not just use the name Modulation_Source for the type name? Usually, better names for the objects of the type are possible so having the _Type in the type name is not necessary.
|
Ah, now I see what you mean. I'll correct this. Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for Si4432 EZRadioPRO ISM Band that supports a frequency range between 240 and 960 MHz and output power range between 1 and 20 dBm