Minor Fixes: optional logsums, duplicate data in parking lot choice, activitysim version to logfile #963
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses the following:
CoPilot provides additional details:
Logsum Calculation Handling:
All affected models (
location_choice.py,trip_destination.py,tour_destination.py,tour_od.py) now check ifLOGSUM_SETTINGSis set before performing logsum calculations, and populate logsum fields with zero when skipped. [1] [2] [3] [4] [5] [6] [7] [8]In
trip_destination.py, reading and using logsum settings is conditional onLOGSUM_SETTINGSbeing set, and downstream code adapts to the absence of these settings. [1] [2]Configuration and API Improvements:
LOGSUM_SETTINGSattribute inLocationComponentSettingsis now explicitly typed asPath | Noneand documented to clarify that logsums are skipped when set toNone.Other Updates:
Bug Fixes: