Skip to content

Conversation

@dhensle
Copy link
Contributor

@dhensle dhensle commented Aug 4, 2025

Addresses the following:

  1. Optionally calculate logsums (Optional Mode Choice Logsum in Destination Choice Model #847)
  2. Duplicate data ending up in parking location choice (Duplicate column names within parking location choice model #633)
  3. ActivitySim version written to logfile (ActivitySim Version in the logfile #690)

CoPilot provides additional details:

Logsum Calculation Handling:

  • All affected models (location_choice.py, trip_destination.py, tour_destination.py, tour_od.py) now check if LOGSUM_SETTINGS is set before performing logsum calculations, and populate logsum fields with zero when skipped. [1] [2] [3] [4] [5] [6] [7] [8]

  • In trip_destination.py, reading and using logsum settings is conditional on LOGSUM_SETTINGS being set, and downstream code adapts to the absence of these settings. [1] [2]

Configuration and API Improvements:

  • The LOGSUM_SETTINGS attribute in LocationComponentSettings is now explicitly typed as Path | None and documented to clarify that logsums are skipped when set to None.

Other Updates:

  • The CLI runner now logs the ActivitySim version at startup for easier debugging and reproducibility.

Bug Fixes:

@dhensle dhensle requested a review from jpn-- August 6, 2025 23:29
@jpn-- jpn-- merged commit 2529e60 into ActivitySim:main Aug 13, 2025
16 of 17 checks passed
@dhensle dhensle deleted the phase9A_minor_fixes branch November 13, 2025 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants