Skip to content

Alt col name bug fix for option to handle larger dataset for location models #798

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jpn-- merged 2 commits into from
Feb 13, 2024
Merged

Alt col name bug fix for option to handle larger dataset for location models #798

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1af9c34
make coding for chunking for generic for other location models
bwentl Feb 12, 2024
0f1e312
Merge branch 'location_estimation_patch_main' of https://github.com/T…
bwentl Feb 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions activitysim/estimation/larch/location_choice.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -208,12 +208,13 @@ def split(a, n):
time_start = datetime.now()
# calculate num_chunks based on chunking_size (or max number of rows per chunk)
num_chunks = int(len(alt_values) / chunking_size)
all_person_ids = list(alt_values["person_id"].unique())
split_ids = list(split(all_person_ids, num_chunks))
id_col_name = alt_values.columns[0]
all_ids = list(alt_values[id_col_name].unique())
split_ids = list(split(all_ids, num_chunks))
x_ca_list = []
i = 0
for chunk_ids in split_ids:
alt_values_i = alt_values[alt_values["person_id"].isin(chunk_ids)]
alt_values_i = alt_values[alt_values[id_col_name].isin(chunk_ids)]
x_ca_i = cv_to_ca(
alt_values_i.set_index([chooser_index_name, alt_values_i.columns[1]])
)
Expand Down