Pydantic 2 #796
Merged
Pydantic 2 #796
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhensle
reviewed
Feb 8, 2024
Contributor
dhensle
left a comment
dhensle
left a comment
There was a problem hiding this comment.
I think we can remove this commented out reference to the old parse_obj() call: https://github.com/camsys/activitysim/blob/pydantic-2/activitysim/core/mp_tasks.py#L890
Other than that, I think it looks good.
This was referenced Feb 14, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update ActivitySim to use Pydantic version 2 for settings validation. There are small changes in the pydantic API to accommodate.
It should be a smidge faster, although settings validation is such a small part of overall runtime that it's likely not noticeable (unless we eventually use Pydantic for more). But more importantly, this is the most up-to-date version of Pydantic so compatibility with that tool and others that rely on it will be more robust.
This PR closes #795