Data Type Optimization #782
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpn--
requested changes
Jan 2, 2024
Member
jpn--
left a comment
jpn--
left a comment
There was a problem hiding this comment.
This is a partial review, there's a lot to go through here and I'm not done but want to share my comments so far instead of holding them all until I'm done.
activitysim/abm/models/util/test/test_mandatory_tour_frequency.py
Outdated
Show resolved
Hide resolved
activitysim/examples/placeholder_psrc/configs/stop_frequency_annotate_tours_preprocessor.csv
Show resolved
Hide resolved
@jpn-- I'm gonna remove these files. I used them to write out the memory of each column in the interaction_df. It was useful when I did the diagnosis, but probably not needed in actual implementation.
…e-dev-merge # Conflicts: # activitysim/core/util.py
relax progressive checks for categorical dtypes
…e-dev-merge # Conflicts: # activitysim/core/interaction_simulate.py
Merge Develop Branch
Contributor
Author
|
@jpn-- seems the change of the black version has caused the linting test to fail. I can update my local black and reformat if you are ok with that. |
Member
No, I made a mistake and clicked the wrong button to merge code into develop I wasn't intending to. I rolled it back, should be better if you just merge in the latest changes from the develop branch. |
Bring in the latest Develop
# Conflicts: # activitysim/abm/models/vehicle_type_choice.py
jpn--
approved these changes
Feb 12, 2024
latest updates from other PRs
Merged
This was referenced Jul 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR for #673