BayDAG Contribution #11: School Escorting Estimation Updates #777
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Most changes are needed to avoid crash if estimation run actually had no school escorting in the input data
dhensle
force-pushed
the
BayDAG_cont11_school_escorting_estimation
branch
from
df0ea65 to
5c1524f
Compare
i-am-sijia
requested changes
Apr 1, 2024
Contributor
i-am-sijia
left a comment
i-am-sijia
left a comment
There was a problem hiding this comment.
Overall the code changes look fine, I have a few comments for you to take a look.
jpn--
approved these changes
Apr 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most changes in this PR are needed to avoid crash if estimation run actually had no school escorting in the input data. Empty school escorting tables are not handled appropriately in the current implementation. This would arise when running estimation mode with a small enough sample that school escorting was not included in the estimation data.
Additional fixes in this PR fix a case where the "gender weight" optional setting used to rank chauffeurs was incorrectly using the person weight setting instead. It also appropriately names the alternative column for estimation mode (see #771).
Required for SANDAG ABM3 production? -- No