Option to write output tables as parquet files #763
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpn--
requested changes
Feb 6, 2024
Member
jpn--
left a comment
jpn--
left a comment
There was a problem hiding this comment.
Looks good, just a few suggested small changes to make this code more future-developer-friendly.
| 'h5_store' defaults to False, which means the output will be written out to csv. | ||
| 'file_type' defaults to 'csv' but can also be used to specify 'parquet' or 'h5'. | ||
| When 'h5_store' is set to True, 'file_type' is ingored and the outputs are written to h5. |
Member
There was a problem hiding this comment.
The old setting should now be deprecated. I opened an issue #791 to address that separate from this PR.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the option to write output tables as parquet files, as described in this issue/feature request.