Skip to content

Fix for zones reopening in simulation-based constraint mechanism for work/school location choice #1028

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dhensle wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Fix for zones reopening in simulation-based constraint mechanism for work/school location choice #1028

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
979eb44
addresses issue with zones reopening after being closed in shadow_pri…
juangacosta Dec 24, 2025
4707554
addresses issue with zones reopening after being closed in shadow_pri…
juangacosta Dec 24, 2025
dbf18b1
adding shadow price regression values
dhensle Dec 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion activitysim/abm/tables/shadow_pricing.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -860,10 +860,20 @@ def update_shadow_prices(self, state):
sprice.replace([np.inf, -np.inf], 0, inplace=True)

# shadow prices are set to -999 if overassigned or 0 if the zone still has room for this segment
self.shadow_prices[segment] = np.where(
old_shadow_prices = self.shadow_prices[segment].values
new_shadow_prices = np.where(
(sprice <= 1 + percent_tolerance / 100), -999, 0
)

# the conditions above allow for zones to be reopened, but we want to prevent such behavior
new_shadow_prices = np.where(
(old_shadow_prices == -999) & (new_shadow_prices != -999),
old_shadow_prices,
new_shadow_prices,
)

self.shadow_prices[segment] = new_shadow_prices

zonal_sample_rate = 1 - sprice
overpredicted_zones = self.shadow_prices[
self.shadow_prices[segment] == -999
Expand Down
Loading
Loading