Skip to content

Conversation

@JoeJimFlood
Copy link
Contributor

This pull request cleans up the logging that was raised in #408, primarily by downgrading multiple instances of logger.info() to logger.debug(). Guidance on what logging level to use for each logging message was also added to the logging documentation. Statements were targeted for demotion by running the prototype_mtc example with the logging level set to INFO and prioritizing statements that were repetitive and not helpful for simply determining where the model was at (but could be useful for debugging). The changes in this pull request result in the size of the output logfile (and by proxy number of messages printed in the console) for the prototype_mtc example decreasing from 3290 KB to 139 KB, a 95.8% reduction.

…) from 20 to 10 so that it's a DEBUG message by default
…it's repetitive and will likely only be of concern during development/debugging
…and simulation in trip destination choice from "INFO" to "DEBUG"
@jpn-- jpn-- self-requested a review October 28, 2025 17:36
Copy link
Member

@jpn-- jpn-- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have reviewed this and found it works as described. There are a few stray messages we could still get and remove from the main logs but that need not hold up approving this.

@jpn-- jpn-- merged commit 335111b into ActivitySim:main Oct 28, 2025
19 checks passed
@jpn-- jpn-- moved this to Done in Phase 11 Nov 6, 2025
@jpn-- jpn-- added this to Phase 11 Nov 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants