Fix for explicit_chunk with non fractional values
#1003
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@i-am-sijia , I did a full sample run with 1.3 million households and 3.28 million population with sharrow and multiprocessing on, and my run completed successfully using whole number explicit_chunk fix you implemented. Thanks! |
m-richards
pushed a commit
to m-richards/activitysim
that referenced
this pull request
Dec 15, 2025
* fix for num_choosers < chunk_size * update assert logic
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses #1002.
explicit_chunkis larger than the number of choosers, the model runs in one chunk, equivalent to chunkless. [1]explicit_chunkbynum_processes, so users don't need to changeexplicit_chunkwhen they changenum_processes. In this case, the value ofexplicit_chunkrepresents the total number of choosers running concurrently across all processes, within a machine's memory limit. [2][3]