Draft: En 426 fix eip scanner include paths #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…IPScanner project
… of the project paths start at the root
…the EIPScanner library
…anner files relative to the root of the EIPScanner library
jan-ati
commented
Sep 25, 2024
Comment on lines
+17
to
+21
| add_subdirectory(cip) | ||
| add_subdirectory(eip) | ||
| add_subdirectory(fileObject) | ||
| add_subdirectory(sockets) | ||
| add_subdirectory(utils) |
There was a problem hiding this comment.
Add a CMakeLists.txt file to every sub_directory to clean up pathing.
Each subdirectory is build independently and then linked back to the parent library
There was a problem hiding this comment.
** Added a source to the parent library.
I found a great source by a maintainer of CMake and updated all of the CMakeLists.txt files to use the target_sources() function.
https://crascit.com/2016/01/31/enhanced-source-file-handling-with-target_sources/
|
NOTE: The unit tests still are not building as expected. This is something that should still be fixed. Afterwards, this branch can be merged back into the forked source |
jan-ati
changed the title
…ies and headers to the correct source
…/include rather than /include/EIPScanner
…-directory without needing to create sub-libraries and link them
…-vendors Added the teknic vendor sources
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modified the include paths for the EIPScanner so that all nested paths are explicit. This removes potential confusion with linking as only the
/usr/local/include/directory needs to be referenced by a cmake project using the EIPScanner.Also updated the Examples to use the EIPScanner library rather than relative paths to the
<PROJECT_DIR>/srcdirectory. That is slighly hacky as a separatecmakeprocess is run. This is required as the EIPScanner library needs to be installed before the examples can be built.