Skip to content

Conversation

@adrianlshaw
Copy link
Contributor

New PR containing code from #213

Consistent ordering of listed errors will be fixed in a separate fix in the future.

@Patater
Copy link
Contributor

Patater commented Sep 4, 2019

This still has a merge commit in it. :(

@Patater
Copy link
Contributor

Patater commented Sep 4, 2019

We prefer to keep the review comments contained in one PR thread where that makes most sense to do. For PR #213, updating the branch there makes sense so we can keep the review history all together. Closing in favor of #213 being updated.

@Patater Patater closed this Sep 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants