Check unused attributes in import and copy #101
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In psa_import_key and psa_copy_key, some information comes from the key data (input buffer or source key) rather than from the attributes: key size for import, key size and type and domain parameters for copy. If an unused attribute is nonzero in the attribute structure, check that it matches the correct value. This protects against application errors.
Add tests where psa_import_key is called with attributes specifying an incorrect size.
Split the test function copy_key into two: one for success and one for failure. Add failure tests where the attributes specify an incorrect type or size.
gilles-peskine-arm
added
enhancement
Patater
approved these changes
May 3, 2019
Contributor
Patater
left a comment
Patater
left a comment
There was a problem hiding this comment.
For real implementation, should expand testing to include properly handling of all optional parameters (type, domain_parameters, bits) for RSA and AES as applicable.
| { | ||
| mbedtls_mpi actual, required; | ||
| int ret; | ||
| mbedtls_mpi_init( &actual ); |
Contributor
There was a problem hiding this comment.
In a real implementation, we might want to comment that this is comparing the public exponent (the only RSA domain parameter).
| goto exit; | ||
| } | ||
| PSA_ASSERT( psa_copy_key( source_handle, | ||
| &target_attributes, &target_handle ) ); |
Contributor
There was a problem hiding this comment.
For real implementation, would recommend asserting target_handle is non-zero upon return
Patater
removed
the
needs: review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the type/size attributes are specified during key creation but not required because they can be inferred from the actual data, check them against the actual data.
This PR adds tests for the type and size, but not for domain parameters which are currently mostly not implemented.
Internal ref: https://github.com/ARMmbed/psa-crypto/issues/140#issuecomment-489107823 — Validating unused attributes in key creation